[linux-cifs-client] [PATCH] cifs: tighten up default file_mode/dir_mode

simo idra at samba.org
Sun Apr 5 14:19:08 GMT 2009


On Sun, 2009-04-05 at 07:33 -0400, Jeff Layton wrote:
> 
> Note that this patch also removes the mandatory locking flags from the
> default file_mode. After having looked at how these flags are used by
> the kernel, I don't think that keeping them as the default offers any
> real benefit. That flag combination makes it so that the kernel
> enforces
> mandatory locking.
> 
> Since the server is going to do that for us anyway, I don't think we
> want the client to enforce this by default on applications that just
> want advisory locks. Anyone that does want this behavior can always
> enable it by setting the file_mode appropriately.

If we don't enforce it, what happen on the client side?
Do we do a synchronous write to the server to find out if the app was
actually able to write? Or are we going to tell the app the write was
fine to find out only later that we were not able to write back to the
server ?

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the linux-cifs-client mailing list