[linux-cifs-client] [PATCH 2/3] [CIFS] Remote DFS root support. Try 2, fixed

[Igor Mammedov]

Jeff Layton wrote:
> On Tue, 17 Mar 2009 19:41:15 +0300
> Igor Mammedov <niallain at gmail.com> wrote:
> 
> Sorry for the delay in reviewing this.
> 
>> Subject: [PATCH 2/3] [CIFS] Remote DFS root support.
>>
>>  Allows to mount share on a server that returns -EREMOTE
>>  at the tree connect stage or at the check on a full path
>>  accessibility.
>>
>> Signed-off-by: Igor Mammedov <niallain at gmail.com>
>> ---
>>  fs/cifs/connect.c |  159 ++++++++++++++++++++++++++++++++++++++++++-----------
>>  1 files changed, 127 insertions(+), 32 deletions(-)
>>
>> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
>> index cd4ccc8..abe54d2 100644
>> --- a/fs/cifs/connect.c
>> +++ b/fs/cifs/connect.c
>> @@ -2214,9 +2214,63 @@ is_path_accessible(int xid, struct cifsTconInfo *tcon,
>>  	return rc;
>>  }
>>  
>> +static void
>> +cleanup_volume_info(struct smb_vol **pvolume_info)
>> +{
>> +	struct smb_vol *volume_info;
>> +
>> +	if (!pvolume_info)
>> +		return;
>> +	volume_info = *pvolume_info;
>> +
>> +	if (!volume_info)
>> +		return;
>> +
>> +	if (volume_info->password != NULL) {
>> +		memset(volume_info->password, 0,
>> +				strlen(volume_info->password));
>> +		kfree(volume_info->password);
>> +	}
> 
> ^^^ this should probably turned into a kzfree() instead.
... 

-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com