[linux-cifs-client] Re: Patch status
Jeff Layton
jlayton at redhat.com
Wed Sep 24 19:42:47 GMT 2008
On Wed, 24 Sep 2008 14:11:38 -0500
"Steve French" <smfrench at gmail.com> wrote:
> I merged patches 1, 2 and 5 from your series. In reviewing patch 6
> ("undo changes in cifs_rename_pending_delete if it errors out"), I
> think we need to be careful to check (QueryFileInfo) the status of the
> DELETE_PENDING flag/attribute - if the file is marked delete pending
> (e.g. due to either the open or the set_file_disposition succeeding)
> there is no need to back out.
>
Good point. I'll have to ponder how best to deal with the delete on
close bit. I suppose it's possible I'm just reaching too hard on this and
trying to undo a busy-unlink or rename that fails midstream is just too
complex a situation to handle sanely...
Thoughts?
--
Jeff Layton <jlayton at redhat.com>
More information about the linux-cifs-client
mailing list