[linux-cifs-client] Re: [PATCH] cifs: fix busy-file renames and refactor cifs_rename ...

[Steve French]

On Mon, Sep 22, 2008 at 7:53 PM, Jeff Layton <jlayton at redhat.com> wrote:
> On Mon, 22 Sep 2008 18:50:39 -0500
> "Steve French" <smfrench at gmail.com> wrote:
>

>> 3) by reordering the FreeXid statement at the beginning of cifs_rename
>> you lose the logging of the function return code on a common case
>> (EXDEV) when the debug flags are turned on in /proc/fs/cifs/
>>
>> -       if (pTcon != cifs_sb_target->tcon) {
>> -               FreeXid(xid);
>> -               return -EXDEV;
>
> Ugh, I really dislike the way that these debug statements are
> tangled up with the Xid allocation code, but I'll respin this
> with that in mind.
>
> Thanks for the review...

If the error case is rare enough, I don't mind the reordering to
eliminate the GetXid/FreeXid but this seems like a common one that we
would want to be able to enable logging for (eventually we may all use
SystemTAP and not have to worry about any static tracing but
presumably aren't there yet)


-- 
Thanks,

Steve