[linux-cifs-client] [PATCH 2/2] cifs: fix busy-file renames and refactor cifs_rename logic

[Jeff Layton]

On Fri, 5 Sep 2008 10:39:33 -0500
"Steve French" <smfrench at gmail.com> wrote:

> Do you think the change to the access requested (from GENERIC_READ to
> ...) is essential (and thus should be split out into patch 1 for
> inclusion in 2.6.27-rc6??).
> 
> On Fri, Sep 5, 2008 at 10:33 AM, Jeff Layton <jlayton at redhat.com> wrote:
> > On Fri, 5 Sep 2008 09:11:34 -0500
> > "Steve French" <smfrench at gmail.com> wrote:
> >
> >> Patch1 would probably apply cleanly.
> >>
> >
> > Here's a respun patch 2. In addition to the fact that renaming
> > hardlinks is supposed to be a no-op after all, this also fixes some of
> > the error handling in the earlier patch (which was wrong in some cases).
> >
> > Steve, does this look OK?
> >
> > --
> > Jeff Layton <jlayton at redhat.com>
> >
> 
> 
> 

Yes. That change is essential. DELETE access is required for trans2
rename to work. That was the first stumbling block that George's
email cleared up for me.

-- 
Jeff Layton <jlayton at redhat.com>