[linux-cifs-client] Re: cifs patch: make cifs_rename handle -EACCES errors

[Steve French]

On Sun, Oct 19, 2008 at 9:00 PM, Jeff Layton <jlayton at redhat.com> wrote:
> On Sun, 19 Oct 2008 20:01:04 -0500
> "Steve French" <smfrench at gmail.com> wrote:
>
>> Looking at your cifs rename patch to add handling for servers with
>> bugs that return EACCES instead of EEXIST, I see multiple problems
>>
>> - if after renaming the target to a temp name, setfiledisposition (of
>> the delete on close flag) fails we are going to "leak" files
>
> I'm not seeing this. As best I can tell, we're always closing the file.
> Could you clarify?

What I meant was that if we have a program which

creates file A
creates file B
renames A to B
deletes B

if setting delete on close fails in your patch we will end up with a
temp file at the end of the sequence which won't go away right?



-- 
Thanks,

Steve