[linux-cifs-client] updated pull request

[Jeff Layton]

On Fri, 17 Oct 2008 15:57:06 -0500
"Steve French" <smfrench at gmail.com> wrote:

> np
> 
> On Fri, Oct 17, 2008 at 3:52 PM, Jeff Layton <jlayton at redhat.com> wrote:
> > On Fri, 17 Oct 2008 15:42:24 -0400
> > Jeff Layton <jlayton at redhat.com> wrote:
> >
> >> Ok, here's an updated pull request. The big change is an patch to add
> >> tracking of the DeletePending flag in cifsInodeInfo. I've also removed
> >> the QPathInfo call from cifs_rename_pending delete since we should now
> >> have reasonably up to date status of the DeletePending flag already.
> >>
> >> Thoughts?
> >>
> >> --------------[snip]-------------
> >> The following changes since commit dd1db2dedc4f6ad736fbba5aa6ecfe6e7c8ee0f4:
> >>   Jeff Layton (1):
> >>         cifs: don't use CREATE_DELETE_ON_CLOSE in cifs_rename_pending_delete
> >>
> >> are available in the git repository at:
> >>
> >>   git://git.samba.org/jlayton/cifs.git cifs-next
> >>
> >> Jeff Layton (8):
> >>       cifs: no need to use rcu_assign_pointer on immutable keys
> >>       cifs: track DeletePending flag in cifsInodeInfo
> >>       cifs: undo changes in cifs_rename_pending_delete if it errors out
> >>       cifs: make cifs_rename handle -EACCES errors
> >>       cifs: remove unused SMB session pointer from struct mid_q_entry
> >>       cifs: clean up server protocol handling for TCP_Server_Info
> >>       cifs: handle the TCP_Server_Info->tsk field more carefully
> >>       cifs: disable sharing session and tcon and add new TCP sharing code
> >>
> >>  fs/cifs/cifs_debug.c  |    2 +-
> >>  fs/cifs/cifs_spnego.c |    2 +-
> >>  fs/cifs/cifsfs.c      |    9 ++
> >>  fs/cifs/cifsglob.h    |   15 +--
> >>  fs/cifs/cifsproto.h   |    1 +
> >>  fs/cifs/cifssmb.c     |   14 +--
> >>  fs/cifs/connect.c     |  229 +++++++++++++++++++------------------------------
> >>  fs/cifs/dns_resolve.c |    2 +-
> >>  fs/cifs/inode.c       |  215 ++++++++++++++++++++++++++++++----------------
> >>  fs/cifs/transport.c   |   13 +--
> >>  10 files changed, 256 insertions(+), 246 deletions(-)
> >>
> >>
> >
> > Actually... I've run into a problem with the new patch to track delete_pending. Please hold off on applying these until I get it straightened out.
> >
> > --
> > Jeff Layton <jlayton at redhat.com>
> >
> 

Ok, I think I got it straightened out. The problem was that CIFSSMBOpen
and SMBOpenLegacy weren't initializing the DeletePending byte in the
FILE_ALL_INFO. Once I fixed that, things worked as expected.

The new set is pushed to git.samba.org...

-- 
Jeff Layton <jlayton at redhat.com>