[linux-cifs-client] cifs and kthread_run / kernel_thread

Jeff Layton jlayton at redhat.com
Wed Oct 15 00:54:25 GMT 2008


On Sat, 31 Mar 2007 06:45:16 +0200
Wilhelm Meier <wilhelm.meier at fh-kl.de> wrote:

> Hi all,
> 
> I would like to use cifs inside linux-vserver guests. Discussion this with the 
> vserver people, we found that cifs is using the new kthread_run and the old 
> kernel_thread interface for starting kernel-threads. The old-style interface 
> renders cifs unusable inside a vserver-guest :-(
> 
> My questions:
> 
> i) Are there newer versions of cifs, where only kthread_run is used in all 
> places?
> 
> If not:
> 
> ii) Are there reasons not to do so?
> 
> iii) Is it difficult to switch to the new interface?
> 
> gs cifs # grep kthread_run *.[ch]
> cifsfs.c:       oplockThread = kthread_run(cifs_oplock_thread, 
> NULL, "cifsoplockd");
> cifsfs.c:       dnotifyThread = kthread_run(cifs_dnotify_thread, 
> NULL, "cifsdnotifyd");
> 
> gs cifs # grep kernel_thread *.[ch]
> cifs.mod.c:     { 0x7e9ebb05, "kernel_thread" },
> connect.c:                      rc = (int)kernel_thread((void *)(void 
> *)cifs_demultiplex_thread, srvTcp,
> 

Hi Wilhelm,

I know the original email here is well over a year old...

I've proposed a patch to remove kthread_stop from the cifsd shutdown
path. I don't see any reason why that should be a problem for
linux-vserver, but if you're still using it, then it might be good to
test out this patchset and see whether it gives you trouble.

I just posted the latest set to the list. It starts with:

Subject: [linux-cifs-client] [PATCH 0/5] cifs: fix deadlocks, oopses and mem corruption with concurrent mount/umount (try #2 resend)

...comments and suggestions appreciated.

Thanks,
-- 
Jeff Layton <jlayton at redhat.com>


More information about the linux-cifs-client mailing list