[linux-cifs-client] Re: Follow up checks for patch "make sure we have the right resume info before calling CIFSFindNext"

Steve French smfrench at gmail.com
Wed Oct 8 18:55:50 GMT 2008


Since we weren't checking for any before  - and the code worked
without last entry saved, won't that (a server returning a bad last
entry) revert to the same behavior as we had before your patch?

On Wed, Oct 8, 2008 at 1:52 PM, Jeff Layton <jlayton at redhat.com> wrote:
> On Wed, 8 Oct 2008 13:17:51 -0500
> "Steve French" <smfrench at gmail.com> wrote:
>
>> This patch adds some primitive checks to make sure the last_entry does
>> not go beyond end of buffer.
>>
>> Should we change the resume key (e.g. to null) if a null resume name
>> is passed in (server sets this file wrong for example)?
>>
>
> Looks good to me, though should we maybe just consider throwing a hard error
> when this occurs? -EIO or something? That might be better than trying to
> work around server bugs, particularly when we're not yet aware of any...
>
> --
> Jeff Layton <jlayton at redhat.com>
>



-- 
Thanks,

Steve


More information about the linux-cifs-client mailing list