[linux-cifs-client] [PATCH 1/6] cifs: convert tcpSem to a mutex
Jeff Layton
jlayton at redhat.com
Sun Nov 30 16:46:50 GMT 2008
On Sun, 30 Nov 2008 11:41:05 -0500
Christoph Hellwig <hch at infradead.org> wrote:
> On Sun, Nov 30, 2008 at 08:57:20AM -0500, Jeff Layton wrote:
> > Mutexes are preferred for single-holder semaphores...
> > + struct mutex tcpMutex;
>
> please rename this to tcp_mutex while you're at it. cifs needs to
> gradually move towards normal Linux style.
>
I think we used srv_count for the new refcounter, so srv_mutex might
be more consistent. I'll plan to do something along those lines on
the next respin...
Thanks,
--
Jeff Layton <jlayton at redhat.com>
More information about the linux-cifs-client
mailing list