[linux-cifs-client] [PATCH 0/6] cifs: clean up socket creation,
connection and send code
Jeff Layton
jlayton at redhat.com
Sun Nov 30 13:57:19 GMT 2008
This patchset is intended as a cleanup of the code that creates and
connects sockets. It's also intended to unify the smb_send and smb_send2
functions, and simplify the sending code in the blocking I/O case. There
is a lot of duplicate code in those functions, and this should make it
easier to ensure that we fix bugs with it properly. This should also
fix the case where we get a partial send in smb_send. Previously, we
did not force a reconnect in that case.
I've tested this code by running many iterations with timed iozone
tests. In general, I found performance with blocking sends to be better
with this patchset, but the numbers were so close that I don't think
they were statistically significant.
This patchset is also intended for 2.6.29 and depends on the 5 patch set
of cleanups that I sent last week.
Jeff Layton (6):
cifs: convert tcpSem to a mutex
cifs: move allocation of new TCP_Server_Info into separate function
cifs: make ipv4_connect take a TCP_Server_Info arg
cifs: make ipv6_connect take a TCP_Server_Info arg
cifs: turn smb_send into a wrapper around smb_send2
cifs: don't retry on blocking sends
fs/cifs/cifsglob.h | 2 +-
fs/cifs/cifsproto.h | 4 +-
fs/cifs/connect.c | 436 ++++++++++++++++++++++++++-------------------------
fs/cifs/transport.c | 147 ++++++------------
4 files changed, 270 insertions(+), 319 deletions(-)
More information about the linux-cifs-client
mailing list