[linux-cifs-client] Re: fsx-linux failing with latest cifs-2.6 git tree

Nick Piggin npiggin at suse.de
Wed Nov 26 13:09:43 GMT 2008


On Wed, Nov 26, 2008 at 07:11:46AM -0500, Jeff Layton wrote:
> On Tue, 25 Nov 2008 22:04:04 -0600
> "Steve French" <smfrench at gmail.com> wrote:
> 
> > Do you know why someone added the AOP_FLAG_UNITERRUPTIBLE check in
> > cifs_write_begin instead of always marking a page up to date if we are
> > writing the whole page?  How often would that flag be set - I only see
> > it in the path which calls generic_file_buffered_write
> > 
> >  	/* If we are writing a full page it will be up to date,
> >  	   no need to read from the server */
> >  	if (len == PAGE_CACHE_SIZE && flags & AOP_FLAG_UNINTERRUPTIBLE)
> > 
> > It seems restrictive
> 
> Given that I now understand what AOP_FLAG_UNINTERRUPTIBLE is supposed
> to do, this patch is probably what we need. Running tests on it now.

That seems pretty reasonable, although keep in mind that
AOP_FLAG_UNINTERRUPTIBLE is not going to be the common case (unless
you're running loop or nfsd or something on the filesystem).

It would be really nice to figure out a way to avoid the reads in
the interruptible case as well.


More information about the linux-cifs-client mailing list