[linux-cifs-client] Shouldn't we free response buffer in
SendReceiveNoRsp?
Jeff Layton
jlayton at redhat.com
Mon Nov 24 14:23:51 GMT 2008
On Fri, 21 Nov 2008 13:12:40 +0300
Igor Mammedov <niallain at gmail.com> wrote:
> Patch is attached in case we should.
>
I don't think we have a leak here. SendReceiveNoRsp does this:
flags |= CIFS_NO_RESP;
SendReceive2 looks like it does this:
if ((flags & CIFS_NO_RESP) == 0)
midQ->resp_buf = NULL; /* mark it so buf will
not be freed by
DeleteMidQEntry */
...and DeleteMidQEntry looks like it does the actual free. It would
however, be nice if this were more obvious.
Cheers,
--
Jeff Layton <jlayton at redhat.com>
More information about the linux-cifs-client
mailing list