[linux-cifs-client] Re: [PATCH] cifs: fix check for dead tcon in smb_init

Steve French smfrench at gmail.com
Tue Nov 18 16:34:56 GMT 2008


Merged into cifs-2.6.git

Interesting that I caught the parallel change in small_smb_init (more
common case) but not this one.

On Tue, Nov 18, 2008 at 9:33 AM, Jeff Layton <jlayton at redhat.com> wrote:
> This was recently changed to check for need_reconnect, but should
> actually be a check for a tidStatus of CifsExiting.
>
> Signed-off-by: Jeff Layton <jlayton at redhat.com>
> ---
>  fs/cifs/cifssmb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> index bdda46d..2af8626 100644
> --- a/fs/cifs/cifssmb.c
> +++ b/fs/cifs/cifssmb.c
> @@ -295,7 +295,7 @@ smb_init(int smb_command, int wct, struct cifsTconInfo *tcon,
>           check for tcp and smb session status done differently
>           for those three - in the calling routine */
>        if (tcon) {
> -               if (tcon->need_reconnect) {
> +               if (tcon->tidStatus == CifsExiting) {
>                        /* only tree disconnect, open, and write,
>                          (and ulogoff which does not have tcon)
>                          are allowed as we start force umount */
> --
> 1.5.5.1
>
>



-- 
Thanks,

Steve


More information about the linux-cifs-client mailing list