[linux-cifs-client] Re: [PATCH] cifs: prevent cifs_writepages() from skipping unwritten pages

[Dave Kleikamp]

On Mon, 2008-11-17 at 12:14 -0600, Shirish S Pargaonkar wrote:

> Is it possible that pagevec_lookup_tag can return less than the pages 
> being looked up, i.e. is it possible that pagevec_lookup_tag could
> return 
> less (8) dirty pages than the number of pages that were asked (14)
> when we 
> are not at the end of the file? 

I'm not sure if there are any conditions that would make it return less
than what we asked for if there are enough dirty pages.  I haven't dug
through the radix-tree code.
> 
> I think this is OK (this is from the previous writes to this file as
> part 
> of this testcase) as we are at the end of the file. 
> 
>   real_write_file (39.test): pos = 24428544, size = 57344, returned
> 57344 
>   real_write_file (39.test): pos = 24485888, size = 57344, returned
> 57344 
>   real_write_file (39.test): pos = 24543232, size = 32768, returned
> 32768 

Of course.
-- 
David Kleikamp
IBM Linux Technology Center