[linux-cifs-client][patch] assign correct values to iov after error in kernel_recvmsg

Steve French smfrench at gmail.com
Mon Nov 3 19:11:39 GMT 2008


This doesn't look right ... smb_msg.,msg_control and msg_controllen
shouldn't be changed (if so could you verify with the linux net
mailing list).   Are you sure that the socket API corrupts the iov
(e.g. iov_len) on EAGAIN?

Did this patch cause a change in the test case?   It is probably
harmless since it sets the values to what I would expect ... but would
like to see if someone on the linux net mailing list could verify.

On Mon, Nov 3, 2008 at 11:46 AM, Shirish Pargaonkar
<shirishpargaonkar at gmail.com> wrote:
> ---------- Forwarded message ----------
> From: Shirish Pargaonkar <shirishpargaonkar at gmail.com>
> Date: Mon, Nov 3, 2008 at 11:15 AM
> Subject: [linux-cifs-client][patch] assign correct values to iov after
> error in kernel_recvmsg
> To: "linux-cifs-client at lists.samba.org" <linux-cifs-client at lists.samba.org>
>
>
> Can't rely on iov length and base being correct when kernel_recvmsg returns
> an error when retrying kernel_recvmsg.
>



-- 
Thanks,

Steve


More information about the linux-cifs-client mailing list