[linux-cifs-client] [PATCH 0/7] [CIFS] clean up cifs_setattr and fix setting of mtimes

Jeff Layton jlayton at redhat.com
Fri May 23 15:50:39 GMT 2008

This patch breaks up the large and unwieldy cifs_setattr function into
multiple pieces. In addition to making the function easier to follow and
reducing indentation, this should also make it easier to implement a
scheme to reduce the amount of times that we retry functions that we
know will fail to a particular server. It also fixes the setting of
mtimes (LastWriteTime) on open files with Windows servers.

This patch is based on top of the "dynperm" patchset that I've been
posting, but which is not yet committed.

Comments and/or suggestions appreciated...


Jeff Layton (7):
      [CIFS] turn cifs_setattr into a multiplexor that calls the correct function
      [CIFS] move file time and dos attribute setting logic into new function
      [CIFS] Rename CIFSSMBSetFileTimes to CIFSSMBSetFileInfo and add PID arg
      [CIFS] change CIFSSMBSetTimes to CIFSSMBSetPathInfo
      [CIFS] spin off cifs_setattr with unix extensions to its own function
      [CIFS] bundle up Unix SET_PATH_INFO args into a struct and change name
      [CIFS] break ATTR_SIZE changes out into their own function

 fs/cifs/cifspdu.h   |    2 
 fs/cifs/cifsproto.h |   24 ++
 fs/cifs/cifssmb.c   |   43 ++--
 fs/cifs/dir.c       |   58 +++--
 fs/cifs/file.c      |   19 +-
 fs/cifs/inode.c     |  551 ++++++++++++++++++++++++++++++++-------------------
 6 files changed, 422 insertions(+), 275 deletions(-)

Signed-off-by: Jeff Layton <jlayton at redhat.com>

More information about the linux-cifs-client mailing list