[linux-cifs-client] Re: add parsing to cifs mount option for mounting to shares which support transport encryption

Miklos Szeredi miklos at szeredi.hu
Thu May 15 17:30:37 GMT 2008


> Samba now supports transport encryption on particular shares (exports)
> - so cifs mount needs to be able to specify whether to do transport
> encryption when mounting to such shares.  This patch adds the parsing
> for the mount option

Please also add it to cifs_show_options().

BTW, cifs is the last filesystem in mainline which is missing a lot of
mount options from its show_options() method.

cifs_parse_mount_options() is also ripe for some cleanups: it's a >500
line function and hacks like the "sep=" option should really be
exterminated.  There are _much_ better ways to escape the separator
charater than to completely replace it.  Like surrounding it with
quotes or prefixing with a backslash.

Miklos


More information about the linux-cifs-client mailing list