[linux-cifs-client] Re: [PATCH] [CIFS] clean legacy cruft out of connect.c

Jeff Layton jlayton at redhat.com
Wed May 7 19:45:27 GMT 2008

On Wed, 7 May 2008 13:57:52 -0500
"Steve French" <smfrench at gmail.com> wrote:

> On Wed, May 7, 2008 at 1:35 PM, Jeff Layton <jlayton at redhat.com> wrote:
> > cifs_setup_session has a lot of legacy cruft. In practice these days,
> >  "experimEnabled" is generally always less than 2. Session setup is
> >  pretty much always handled by CIFS_SessSetup. This patch eliminates
> >  the unused code in that function and does some cleanup to reduce the
> >  amount of indentation. It also removes 3 session setup functions that
> >  are now handled by CIFS_SessSetup.
> >
> >  I know there was some concern that there was some logic in this code to
> >  which we wanted to be able to refer later. Anyone needing to do that
> >  though can always just pull up an old git tree, so there's not much
> >  reason to keep the current code cluttered up with it.
> >
> >  Signed-off-by: Jeff Layton <jlayton at redhat.com>
> The main thing I wanted to double check before removal is whether
> NTLMSSP enablement works without switching this old code back on or
> whether there are any legacy LANMAN cases which require any of these
> old disabled-by-default routines.

Ok. I'd be willing to do some of this testing if you can suggest server
configurations where the old code might still be needed.

Jeff Layton <jlayton at redhat.com>

More information about the linux-cifs-client mailing list