[linux-cifs-client] [PATCH 1/4] [CIFS] remove unneeded half-second sleep from cifs_umount

Jeff Layton jlayton at redhat.com
Fri May 2 19:25:17 GMT 2008


As best I can tell, this sleep was intended to try to prevent
cifs_umount from freeing the cifsSesInfo struct before cifsd had
exited. Now that cifsd is using the kthread API, we know that
when kthread_stop returns that cifsd has exited, so I don't
think this is needed any longer.

Signed-off-by: Jeff Layton <jlayton at redhat.com>
---
 fs/cifs/connect.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 6c4332f..f4a668b 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3556,8 +3556,6 @@ cifs_umount(struct super_block *sb, struct cifs_sb_info *cifs_sb)
 	cifs_sb->prepath = NULL;
 	kfree(tmp);
 	if (ses)
-		schedule_timeout_interruptible(msecs_to_jiffies(500));
-	if (ses)
 		sesInfoFree(ses);
 
 	FreeXid(xid);
-- 
1.5.3.6



More information about the linux-cifs-client mailing list