[linux-cifs-client] [PATCH 3/3] [CIFS] remove unneeded half-second sleep from cifs_umount

Jeff Layton jlayton at redhat.com
Thu May 1 18:35:20 GMT 2008

On Thu, 1 May 2008 12:31:06 -0400
Christoph Hellwig <hch at infradead.org> wrote:

> On Thu, Apr 17, 2008 at 04:59:06PM -0400, Jeff Layton wrote:
> > I can't see any reason for this sleep, and it slows down umounts.
> Looks odd to me aswell.  Maybe Steve has an idea?

The only thing I can figure is that it was intended to give cifsd time
to come down before freeing the cifsSesInfo struct. Sounds like a racy
proposition though :-)

Now that cifsd is kthread based, we know that it's down once
kthread_stop returns. If that was the original reason, then we
definitely don't need it anymore.

Jeff Layton <jlayton at redhat.com>

More information about the linux-cifs-client mailing list