[linux-cifs-client] cifs_mount() contains strange code

[Q (Igor Mammedov)]

This code never worked, hence rc = -ENODEV here to report that it is not
possible
to mount remote dfs_root. I'm thinking on rewriting cifs_mount/umount and
related
functions to actually provide this feature, after all basic dfs code is in
mainline.

On Thu, Mar 27, 2008 at 8:34 PM, Adrian Bunk <bunk at kernel.org> wrote:

> This looks somehow fishy (note the "rc" settings):
>
> <--  snip  -->
>
> ....
> int
> cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
>           char *mount_data, const char *devname)
> {
> ....
>                                /* BB check if this works for exactly
> length
>                                 * three strings */
>                                if ((strchr(volume_info.UNC + 3, '\\') ==
> NULL)
>                                    && (strchr(volume_info.UNC + 3, '/') ==
>                                        NULL)) {
>                                        rc = connect_to_dfs_path(xid,
> pSesInfo,
>                                                "", cifs_sb->local_nls,
>                                                cifs_sb->mnt_cifs_flags &
>
>  CIFS_MOUNT_MAP_SPECIAL_CHR);
>                                        rc = -ENODEV;
>                                        goto out;
>
> <--  snip  -->
>
> cu
> Adrian
>
> --
>
>       "Is there not promise of rain?" Ling Tan asked suddenly out
>        of the darkness. There had been need of rain for many days.
>       "Only a promise," Lao Er said.
>                                       Pearl S. Buck - Dragon Seed
>
> _______________________________________________
> linux-cifs-client mailing list
> linux-cifs-client at lists.samba.org
> https://lists.samba.org/mailman/listinfo/linux-cifs-client
>
-------------- next part --------------
HTML attachment scrubbed and removed