[linux-cifs-client] Re: [patch] get security descriptor results in oplock

[Steve French]

On 3/13/08, Shirish Pargaonkar <shirishpargaonkar at gmail.com> wrote:
> With cifsacl mount option, when a file is created on the Windows server,
> exclusive oplock is broken right away because the get cifs acl code
> again opens the file to obtain security descriptor.
> The client does not have the newly created file handle or inode in any
> of its lists yet
> so it does not respond to oplock break and the server waits for its
> set duration and
> then responds to the second open. This slows down file creation signficantly.
> The fix is to pass the file descriptor to the get cifsacl code
> wherever available
> so that get cifs acl code does not send second open (NT Create ANDX)
> and oplock is not broken.

Shirish,
Here is a different version, although similar idea to what you tried

1) simplified (does not increasing nesting in cifsacl.c)
2) variable name changed from fileHandle to pfid
3) changed to const

Would you try it out and review it - we are quickly running out of runway.



-- 
Thanks,

Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: acl-oplock.patch
Type: text/x-diff
Size: 7780 bytes
Desc: not available
Url : http://lists.samba.org/archive/linux-cifs-client/attachments/20080314/85552988/acl-oplock.bin