[linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

[Q (Igor Mammedov)]

Hi Steve,

Looked through inode.c code again and rewrote/simplified patch5 
See attachment for it.


Q (Igor Mammedov) wrote:
> Sorry guys, but I have a lot of work for the last 3 weeks,
> so I couldn't spare much time for a hobby and react quickly.
> 
 > Also I noticed that patch 2/5 is not completely applied yet. I'll send Steve
> interim patch I've made to make thing compiled and working.
> 
> Christoph Hellwig wrote:
>> +#ifdef CONFIG_CIFS_DFS_UPCALL
>> +			if (is_remote) {
>> +				inode->i_op =
>> +					&cifs_dfs_referral_inode_operations;
>> +				inode->i_fop = NULL;
>>
>> i_fop should never be set to NULL.  Just leave it alone so it stays
>> at &empty_fops.
>>
>> +#ifdef CONFIG_CIFS_DFS_UPCALL
>> +			if (is_remote) {
>> +				inode->i_op =
>> +					&cifs_dfs_referral_inode_operations;
>> +				inode->i_fop = NULL;
>> +			} else {
>> +				inode->i_op = &cifs_dir_inode_ops;
>> +				inode->i_fop = &cifs_dir_ops;
>> +			}
>> +#else
>>  			inode->i_op = &cifs_dir_inode_ops;
>>  			inode->i_fop = &cifs_dir_ops;
>> +#endif
>>
>> This code and everything surrounding it is duplicated in two functions.
>> Please refactor it into a common helper before adding new code to it.
>>
>> _______________________________________________
>> linux-cifs-client mailing list
>> linux-cifs-client at lists.samba.org
>> https://lists.samba.org/mailman/listinfo/linux-cifs-client
>>
>> .
>>
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> linux-cifs-client mailing list
> linux-cifs-client at lists.samba.org
> https://lists.samba.org/mailman/listinfo/linux-cifs-client


-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com




-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-DFS-patch-that-connects-inode-with-dfs-handling-ops.patch
Type: text/x-patch
Size: 7994 bytes
Desc: not available
Url : http://lists.samba.org/archive/linux-cifs-client/attachments/20080304/f4c1681a/0005-DFS-patch-that-connects-inode-with-dfs-handling-ops.bin