[linux-cifs-client] [PATCH]: Supress a `comparison is always false' warning in fs/cifs/asn1.c

Suresh Jayaraman sjayaraman at suse.de
Wed Jun 11 07:15:12 GMT 2008


On x86_64, I get this warning:

fs/cifs/asn1.c: In function `asn1_oid_decode':
fs/cifs/asn1.c:403: warning: comparison is always false due to limited
range of data type

Signed-off-by: Suresh Jayaraman <sjayaraman at suse.de>
---

diff --git a/fs/cifs/asn1.c b/fs/cifs/asn1.c
index f58e41d..4bdf809 100644
--- a/fs/cifs/asn1.c
+++ b/fs/cifs/asn1.c
@@ -400,7 +400,7 @@ asn1_oid_decode(struct asn1_ctx *ctx,
 	size = eoc - ctx->pointer + 1;
 
 	/* first subid actually encodes first two subids */
-	if (size < 2 || size > ULONG_MAX/sizeof(unsigned long))
+	if (size < 2 || size > UINT_MAX/sizeof(unsigned int))
 		return 0;
 
 	*oid = kmalloc(size * sizeof(unsigned long), GFP_ATOMIC);



More information about the linux-cifs-client mailing list