[linux-cifs-client] [PATCH 0/7] [CIFS] clean up cifs_setattr
and fix setting of mtimes
Jeff Layton
jlayton at redhat.com
Tue Jun 3 14:06:27 GMT 2008
On Fri, 23 May 2008 11:50:39 -0400
Jeff Layton <jlayton at redhat.com> wrote:
> This patch breaks up the large and unwieldy cifs_setattr function into
> multiple pieces. In addition to making the function easier to follow and
> reducing indentation, this should also make it easier to implement a
> scheme to reduce the amount of times that we retry functions that we
> know will fail to a particular server. It also fixes the setting of
> mtimes (LastWriteTime) on open files with Windows servers.
>
> This patch is based on top of the "dynperm" patchset that I've been
> posting, but which is not yet committed.
>
> Comments and/or suggestions appreciated...
>
Hi Steve,
Now that the dynperm patchset is in, any thoughts on this one?
Anything amiss, or does it look OK as-is?
If it's OK as-is, then I recommend applying them in order. I'm pretty
sure that that should keep things cleanly bisectable, but I've only
really tested the entire patchset as a whole.
Thanks,
--
Jeff Layton <jlayton at redhat.com>
More information about the linux-cifs-client
mailing list