[linux-cifs-client] review 5, was Re: projected date for mount.cifs to support DFS junction points

[Q (Igor Mammedov)]

Sorry guys, but I have a lot of work for the last 3 weeks,
so I couldn't spare much time for a hobby and react quickly.

Here is what I've done the last weekend.
Attached:
 fixed patch [5/5] (0001-DFS-patch-that-connects-inode-with-dfs-handling-ops.patch).
 fixed mixed case in struct member (0002-Fixed-mixed-case-name-in-structure-dfs_info3_param.patch)


Also I noticed that patch 2/5 is not completely applied yet. I'll send Steve
interim patch I've made to make thing compiled and working.

Christoph Hellwig wrote:
> +#ifdef CONFIG_CIFS_DFS_UPCALL
> +			if (is_remote) {
> +				inode->i_op =
> +					&cifs_dfs_referral_inode_operations;
> +				inode->i_fop = NULL;
> 
> i_fop should never be set to NULL.  Just leave it alone so it stays
> at &empty_fops.
> 
> +#ifdef CONFIG_CIFS_DFS_UPCALL
> +			if (is_remote) {
> +				inode->i_op =
> +					&cifs_dfs_referral_inode_operations;
> +				inode->i_fop = NULL;
> +			} else {
> +				inode->i_op = &cifs_dir_inode_ops;
> +				inode->i_fop = &cifs_dir_ops;
> +			}
> +#else
>  			inode->i_op = &cifs_dir_inode_ops;
>  			inode->i_fop = &cifs_dir_ops;
> +#endif
> 
> This code and everything surrounding it is duplicated in two functions.
> Please refactor it into a common helper before adding new code to it.
> 
> _______________________________________________
> linux-cifs-client mailing list
> linux-cifs-client at lists.samba.org
> https://lists.samba.org/mailman/listinfo/linux-cifs-client
> 
> .
> 


-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com




-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-DFS-patch-that-connects-inode-with-dfs-handling-ops.patch
Type: text/x-patch
Size: 7131 bytes
Desc: not available
Url : http://lists.samba.org/archive/linux-cifs-client/attachments/20080215/104a2554/0001-DFS-patch-that-connects-inode-with-dfs-handling-ops.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fixed-mixed-case-name-in-structure-dfs_info3_param.patch
Type: text/x-patch
Size: 1255 bytes
Desc: not available
Url : http://lists.samba.org/archive/linux-cifs-client/attachments/20080215/104a2554/0002-Fixed-mixed-case-name-in-structure-dfs_info3_param.bin