[linux-cifs-client] CIFS cleanup patch series for vl

Steve French smfrench at gmail.com
Mon Dec 8 21:05:28 GMT 2008


Volker,
I have reviewed and merged into cifs-2.6.git the 2nd through 4th of your
recent 15 patch cleanup series (see below).   Thanks - these were nicely
done.   I mentioned the changes I would prefer in your first patch (
http://git.samba.org/?p=vl/cifs.git;a=commit;h=ad0cf2f565b6f8061a281078c278043c8f98f250),
and I am still reviewing the fifth through fifteenth in your patch series on
http://git.samba.org/?p=vl/cifs.git;a=summary

Welcome back to kernel development.

commit 4d2c688f576208bb0ac6eb3aedb41e3ef561cde7
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 8 20:59:39 2008 +0000

    [CIFS] Slightly simplify wait_for_free_request(), remove an unnecessary
"else" branch

    This is no functional change, because in the "if" branch we do an early
    "return 0;".

    Signed-off-by: Volker Lendecke <vl at samba.org>
    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 38d6c6b3663f214a45ea1581e65555bccc7fcbb7
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Dec 6 13:12:34 2008 +0100

    Simplify allocate_mid() slightly: Remove some unnecessary "else"
branches

    Simplify allocate_mid() slightly: Remove some unnecessary "else"
branches

    Signed-off-by: Volker Lendecke <vl at samba.org>
    Acked-by: Jeff Layton <jlayton at redhat.com>
    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 06caf7068aa54238b9323950fe607a1dea85e133
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 8 20:50:24 2008 +0000

    [CIFS] In SendReceive, move consistency check out of the mutexed region

    inbuf->smb_buf_length does not change in in wait_for_free_request() or
in
    allocate_mid(), so we can check it early.

    Signed-off-by: Volker Lendecke <vl at samba.org>
    Acked-by: Jeff Layton <jlayton at redhat.com>
    Signed-off-by: Steve French <sfrench at us.ibm.com>


-- 
Thanks,

Steve
-------------- next part --------------
HTML attachment scrubbed and removed


More information about the linux-cifs-client mailing list