[linux-cifs-client] [PATCH] cifs: no need to use rcu_assign_pointer
on immutable keys
Jeff Layton
jlayton at redhat.com
Tue Aug 26 20:35:14 GMT 2008
Neither keytype in use by CIFS has an "update" method. This means that
the keys are immutable once instantiated. We don't need to use RCU
to set the payload data pointers.
Signed-off-by: Jeff Layton <jlayton at redhat.com>
---
fs/cifs/cifs_spnego.c | 2 +-
fs/cifs/dns_resolve.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/cifs_spnego.c b/fs/cifs/cifs_spnego.c
index 117ef4b..1ab3a6c 100644
--- a/fs/cifs/cifs_spnego.c
+++ b/fs/cifs/cifs_spnego.c
@@ -41,7 +41,7 @@ cifs_spnego_key_instantiate(struct key *key, const void *data, size_t datalen)
/* attach the data */
memcpy(payload, data, datalen);
- rcu_assign_pointer(key->payload.data, payload);
+ key->payload.data = payload;
ret = 0;
error:
diff --git a/fs/cifs/dns_resolve.c b/fs/cifs/dns_resolve.c
index a2e0673..2569677 100644
--- a/fs/cifs/dns_resolve.c
+++ b/fs/cifs/dns_resolve.c
@@ -42,7 +42,7 @@ static int dns_resolver_instantiate(struct key *key, const void *data,
memcpy(ip, data, datalen);
ip[datalen] = '\0';
- rcu_assign_pointer(key->payload.data, ip);
+ key->payload.data = ip;
return rc;
}
--
1.5.5.1
More information about the linux-cifs-client
mailing list