[linux-cifs-client] [PATCH 2/2] cifs.upcall: enable building by default on linux

[Jeff Layton]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 17 Aug 2008 10:19:38 -0400
simo <idra at samba.org> wrote:

> On Sat, 2008-08-16 at 22:29 -0400, jlayton at samba.org wrote:
> > -[AS_HELP_STRING([--with-cifsupcall], [Include cifs.upcall (Linux
> > only) support (default=no)])],
> > +[AS_HELP_STRING([--with-cifsupcall], [Include cifs.upcall (Linux
> > only) support (default=yes)])],
> 
> this should be probably marked as "default=auto" meaning that configure
> will determine whether it is appropriate or not for the platform it is
> being built on. It is how we mark any other option like this.
> 
> Simo.
> 

We're using more or less the same logic here as mount.cifs and for
that, the default is listed as "yes". They already say "Linux only", so
it seems to me like "yes" is a reasonable way to list the default.

If you think this needs to be changed though, then we should also
change it for mount.cifs.

- -- 
Jeff Layton <jlayton at samba.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEARECAAYFAkioU9YACgkQojH4PzJJfGW6DgCg7pLklG5L2PdjYXX0RLpu/Vs/
QKEAn0O0GMSZ12wqY05GcSjdfa7L7TJO
=rMRi
-----END PGP SIGNATURE-----