[linux-cifs-client] Re: linux-next: manual merge of the creds tree

[Jeff Layton]

On Fri, 8 Aug 2008 10:25:03 -0500
"Steve French" <smfrench at gmail.com> wrote:

> On Fri, Aug 8, 2008 at 6:41 AM, Jeff Layton <jlayton at redhat.com> wrote:
> > On Fri, 8 Aug 2008 16:03:03 +1000
> > Stephen Rothwell <sfr at canb.auug.org.au> wrote:
> >
> >> Hi David,
> >>
> >> On Fri, 8 Aug 2008 16:01:43 +1000 Stephen Rothwell <sfr at canb.auug.org.au> wrote:
> >> >
> >> > Today's linux-next merge of the creds tree got conflicts in fs/cifs/dir.c
> >> > between commits 4e1e7fb9e879d48011a887715d7966484d9644ea ("bundle up Unix
> >> > SET_PATH_INFO args into a struct and change name") and
> >> > 95089910933e10768cfef1ab0bab0c55b962aacb ("[CIFS] cifs_mkdir and
> >> > cifs_create should respect the setgid bit on parent dir") from the cifs
> >> > tree and commit 785af0f385cd424d4b40908bf0e467df3dc05434 ("CRED: Change
> >> > current->fs[ug]id to current_fs[ug]id()") from the creds tree.
> FYI - am waiting on more test feedback from the usual cifs community
> before pushing those
> cifs-2.6.git changes up to mainline.    In my testing of the current
> cifs-2.6 tree,
> there are a couple things I noticed in testing against various Samba
> versions, but it looks like
> they were Samba problems that have been fixed (still investigating).
> I am particularly
> interested in attribute, size, time stamp related testing against non-Windows,
> non-current-Samba servers ...
> 
> 

Hmmm...non-windows and non-current-samba...

Tested against an older netapp (ONTAP Release 7.1.2.1) and don't see
any regressions:

attributes (dos read only attr)		: works correctly
timestamps (cp -p preserves times)	: works correctly 
size change (truncate to 0)		: doesn't work

...the size change doesn't work here on older kernels either (pre-setattr
cleanup). Setting the size via path fails (-EOPNOTSUPP). CIFS tries to do
a legacy open, zero length write and then close. This returns success but
the file's size isn't changed.

I'll see if I can dig up some other oddball CIFS servers to test
against...

-- 
Jeff Layton <jlayton at redhat.com>