[linux-cifs-client] Re: [PATCH] clean legacy cruft out of connect.c

[Steve French]

I did do some cleanup to the legacy session setup function somewhat similar to
what you modified at the end of your patch (adding a goto to remove
the need for one level of
nesting which cleaned up all of the > 80 column lines in the old code there).

On Tue, Aug 5, 2008 at 11:57 PM, Steve French <smfrench at gmail.com> wrote:
> Jeff,
> I didn't merge this since patch 9 code path looks wrong when
>
>   pSesInfo->server->maxBuf != 0
>
> In that case (reconnect) then session setup
>      rc = CIFS_SessSetup(xid, pSesInfo, first_time, nls_info);
> would not have been called with your patch
>
> when maxBuf is zero we know sending a negotiate protocol is needed
> (and also sessionsetup) but when we know that we have
> already negotiated and don't need to resend negprot we
> still need to send a sessionsetup
>
> Although it doesn't really matter (as you note it is disabled until the user
> turns on the experimental flag)  - I would rather wait on removing the
> NTLMSSP implementation
> when we readd a better one based on the documentation - since some
> servers may require
> NTLMSSP and it is not something we should have to upcall to do
> --
> Thanks,
>
> Steve
>



-- 
Thanks,

Steve