[linux-cifs-client] [PATCH] [CIFS] Fix missing braces in cifs_revalidate()

Suresh Jayaraman sjayaraman at suse.de
Tue Aug 5 09:55:23 GMT 2008


Reposting in appropriate format.

Fix missing braces introduced during commit
cea218054ad277d6c126890213afde07b4eb1602.  Though setting wbrc to 0
keeps this from causing real bug, this should have been there.

Acked-by: Jeff Layton <jlayton at redhat.com>
Signed-off-by: Suresh Jayaraman <sjayaraman at suse.de>
---
 fs/cifs/inode.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
index 46e54d3..0e5dccc 100644
--- a/fs/cifs/inode.c
+++ b/fs/cifs/inode.c
@@ -1310,10 +1310,11 @@ int cifs_revalidate(struct dentry *direntry)
 /*		if (S_ISDIR(direntry->d_inode->i_mode))
 			shrink_dcache_parent(direntry); */
 		if (S_ISREG(direntry->d_inode->i_mode)) {
-			if (direntry->d_inode->i_mapping)
+			if (direntry->d_inode->i_mapping) {
 				wbrc = filemap_fdatawait(direntry->d_inode->i_mapping);
 				if (wbrc)
 					CIFS_I(direntry->d_inode)->write_behind_rc = wbrc;
+			}
 			/* may eventually have to do this for open files too */
 			if (list_empty(&(cifsInode->openFileList))) {
 				/* changed on server - flush read ahead pages */


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-missing-brace.patch
Type: text/x-patch
Size: 1202 bytes
Desc: not available
Url : http://lists.samba.org/archive/linux-cifs-client/attachments/20080805/daa8fd4a/fix-missing-brace-0001.bin


More information about the linux-cifs-client mailing list