[linux-cifs-client] Re: [PATCH] [CIFS] remove duplicate mode_to_acl call in cifs_setattr

[Steve French]

Merged into cifs-2.6.git

On Tue, Apr 29, 2008 at 2:51 PM, Jeff Layton <jlayton at redhat.com> wrote:
> The current logic in cifs_setattr calls mode_to_acl twice on mode
>  changes if cifsacl is enabled. Remove the duplicate call.
>  ---
>
>   fs/cifs/inode.c |    4 ----
>   1 files changed, 0 insertions(+), 4 deletions(-)
>
>  diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
>  index 8eaa9e7..a1f24bd 100644
>  --- a/fs/cifs/inode.c
>  +++ b/fs/cifs/inode.c
>  @@ -1581,10 +1581,6 @@ int cifs_setattr(struct dentry *direntry, struct iattr *attrs)
>                         if (time_buf.Attributes == 0)
>                                 time_buf.Attributes |= cpu_to_le32(ATTR_NORMAL);
>                 }
>  -#ifdef CONFIG_CIFS_EXPERIMENTAL
>  -               if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_ACL)
>  -                       mode_to_acl(direntry->d_inode, full_path, mode);
>  -#endif
>         }
>
>         if (attrs->ia_valid & ATTR_ATIME) {
>
>



-- 
Thanks,

Steve