[linux-cifs-client] [PATCH 4/5] [CIFS] have CIFSSMBNegotiate handle SPNEGO via upcall

[Q (Igor Mammedov)]

Jeff Layton wrote:
> I just realized that this patch has a significant (and rather
> boneheaded) bug. If we call cifs_setup_session on a reconnect, then
> we'll end up calling CIFS_SessSetup with a NULL spnego_key. I'm still
> looking at the right way to fix it, but anyone testing this should be
> aware of this. I'll repost once I have a solution and have tested it.

Then you could consider abandoning CIFSSMBNegotiate and moving to 
CIFS_SessSetup for handling SPNEGO stuff. That will simplify your patch: 
make a change in one place instead of many.

PS:
  And it will look more like mine patch :) (in the end).


-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com