[linux-cifs-client] Kerberos5 support in cifs pathset [PATCH: 3/4] upcall handling via KEYS API for getting security blob and session key

[Q (Igor Mammedov)]

Jeff Layton wrote:
> 
> I took the approach of passing around a key pointer to avoid some of
> the copying, but I do the upcall in CIFSSMBNegotiate instead of during
> CIFS_SessSetup.

Passing pointer is fine as far as data copied form key storage so that 
key could be destroyed and key description could be reused for the next 
possible negotiation steps.

As for CIFSSMBNegotiate vs CIFS_SessSetup I thought that in case of 
multi-stage negotiation we would have to do upcalls in CIFS_SessSetup 
too. That's why I've did it CIFS_SessSetup.



>> +			} else
>> +				ascii_ssetup_strings(&bcc_ptr, ses,
>> nls_cp);
> 
> Interesting. Is this correct? If unicode isn't enabled can we just call
> ascii_ssetup_strings here? I've actually not seen any non-unicode
> kerberos setups in the wild. Is it even possible?

Probably not, but just in case it happens ...


-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com