[linux-cifs-client] Kerberos5 support in cifs pathset [PATCH: 1/4] adds support for signing required for kerberos

Jeff Layton jlayton at redhat.com
Tue Oct 23 13:06:03 GMT 2007


On Mon, 22 Oct 2007 21:09:21 +0400
"Q (Igor Mammedov)" <qwerty0987654321 at mail.ru> wrote:

Much of what this patch does already seems to be incorporated with the
patch that fixed NTLMv2 signatures. mac_keys are now stored as structs
with a length and a union. We should be able to just add a new union
member to the mac_signing_key for kerberos (unless it's identical to
ntlmv2 case, in which case we might want to rename that union member).

I think that we'll probably have the upcall return a signing key (as
your design already does). We'll need something analogous to the
ntlmv2_resp struct for kerberos, but I'm unclear on what that should
look like. If you have insight into that, please let me know.

> 
> diff -b -B -N -u -r linux-2.6.22.9/fs/cifs/cifsencrypt.c linux-2.6.22.9/fs/cifs.krb5/cifsencrypt.c
> --- linux-2.6.22.9/fs/cifs/cifsencrypt.c	2007-09-26 22:03:01.000000000 +0400
> +++ linux-2.6.22.9/fs/cifs.krb5/cifsencrypt.c	2007-10-22 19:12:24.000000000 +0400
> @@ -40,8 +40,8 @@

As a side note...

If you're using "diff" directly, you should also use '-p' when generating
C patches. It shows the C function being modified and that makes things
easier to review. 


-- 
Jeff Layton <jlayton at redhat.com>


More information about the linux-cifs-client mailing list