[linux-cifs-client] [PATCH 5/5] [CIFS] have CIFS_SessSetup build correct SPNEGO SessionSetup request

[Q (Igor Mammedov)]

Jeff Layton wrote:
> +		ses->server->mac_signing_key.len = msg->sesskey_len;
> +		memcpy(ses->server->mac_signing_key.data.krb5, msg->data,
> +			msg->sesskey_len);

Possible memory corruption here. Strictly speaking we don't have control 
over key length, it depends on krb server and client implementation/settings. 
Taking into account that session setup doesn't happen very often it wouldn't 
hurt to check if the size of mac_signing_key.data.krb5 is suitable or
bail out in case of overflow.

-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com