[linux-cifs-client] [PATCH 2/2] cifs.spnego helper in samba: helper source code

Jeff Layton jlayton at redhat.com
Thu Nov 15 11:29:19 GMT 2007


On Thu, 15 Nov 2007 13:22:45 +0300
"Q (Igor Mammedov)" <qwerty0987654321 at mail.ru> wrote:

> Jeff Layton wrote:
> >> +	rc = decode_key_description( argv[2],
> >> &kernel_upcall_version, &sectype,
> >> +			&hostname, &uid);
> > 
> > Rather than depending on argv[2], I'd suggest a call to
> > keyctl_describe_alloc() to get the string. That makes this less
> > reliant on someone setting up request-key.conf correctly.
> 
> Shouldn't we add something like "ver=" token in the key description 
> then? It will make things a little clear and helper will not depend
> on the position of description in the returned buffer in case of
> output format changing.
> 

That sounds reasonable. I need respin the remaining patches anyway, so
I'll plan to incorporate this when I do...

-- 
Jeff Layton <jlayton at redhat.com>


More information about the linux-cifs-client mailing list