[linux-cifs-client] [PATCH 2/2] cifs.spnego helper in samba: helper source code

Q (Igor Mammedov) qwerty0987654321 at mail.ru
Thu Nov 15 10:22:45 GMT 2007


Jeff Layton wrote:
>> +	rc = decode_key_description( argv[2], &kernel_upcall_version, &sectype,
>> +			&hostname, &uid);
> 
> Rather than depending on argv[2], I'd suggest a call to
> keyctl_describe_alloc() to get the string. That makes this less reliant
> on someone setting up request-key.conf correctly.

Shouldn't we add something like "ver=" token in the key description 
then? It will make things a little clear and helper will not depend on 
the position of description in the returned buffer in case of output 
format changing.

-- 

Best regards,

-------------------------
Igor Mammedov,
niallain "at" gmail.com






More information about the linux-cifs-client mailing list