[linux-cifs-client] [PATCH 2/2] cifs.spnego helper in samba: helper source code

[simo]

On Wed, 2007-11-14 at 12:16 -0500, Jeff Layton wrote:
> On Wed, 14 Nov 2007 19:34:49 +0300
> "Q (Igor Mammedov)" <qwerty0987654321 at mail.ru> wrote:
> 
> 
> > >> +			strncpy(princ,"cifs/",len);
> > >> +			strncpy(princ+5,hostname,len-5);
> > > 
> > > Idle speculation here -- do we need to allow for service principals
> > > that don't match cifs/hostname at REALM? If I'm looking at packet
> > > captures correctly, it looks like windows boxes use
> > > host/hostname at REALM. Perhaps we should consider falling back to
> > > that if we can't get a key for cifs/hostname?
> > 
> > Could be done but do we really need it?
> > I've tested in within w2003k environment and it happy with  "cifs/".
> > Can change to "host/" if somebody wish it.
> > 
> 
> Ok, if this will universally work then I'd say there's no need to worry
> about it (we can always change it later if the need arises anyway).
> 
> The only other thing that I see with this code is that there's a lot of
> inconsistent spacing. I'm not sure how receptive the samba guys will
> be to that. It might not hurt to run this code through indent and then
> test the result.
> 
> But that's really a minor nit...

The Windows KDC supports aliasing cifs/ with host/, it maybe worth being
able to pass an arbitrary value tho, at the very least for testing
purposes.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>