[linux-cifs-client] [PATCH 4/6] [CIFS] change cifs_setup_session to take a unc string arg

Jeff Layton jlayton at redhat.com
Wed Nov 7 12:33:30 GMT 2007


On Wed, 07 Nov 2007 14:31:32 +0300
"Q (Igor Mammedov)" <qwerty0987654321 at mail.ru> wrote:

> Wouldn't it be better if we saved hostname portion of unc in some
> field of TCP_Server_Info struct? That would result in more
> reusability of it in future and we wouldn't have to change signatures
> whenever we wish to use it.
> 

Possibly. Can you give an example of another place where we'd want to
use it? I'd prefer to not bloat out structs with fields for which we
don't have a clear need. We can always change that later as well...

-- 
Jeff Layton <jlayton at redhat.com>


More information about the linux-cifs-client mailing list