[linux-cifs-client] Re: [PATCH] cifs: remove useless cargo-cult checks

Steven French sfrench at us.ibm.com
Wed Mar 7 18:51:04 GMT 2007






> file->f_path.dentry or file->f_path.dentry.d_inode can't be NULL

OK - I don't really mind removing these checks - and I agree that I there
is not an obvious way that they can be null, yet we had a case in which
file->f_dentry was reported as NULL a few years back in a bug report that
we could not reproduce.

The change to f_path.dentry did hit all filesystems (not sure who did it
last year) and that patch did hit lkml - so this is not something new that
just slipped in.

Is there an easy way to mirror particular patches going into the
cifs-2.6.git tree (which is pulled into mm) to lkml?

The cifs patches go in mm for at least a week before they go into kernel
but some of them I would like to post again to lkml.


Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294
email: sfrench at-sign us dot ibm dot com
-------------- next part --------------
HTML attachment scrubbed and removed


More information about the linux-cifs-client mailing list