[linux-cifs-client] Re: [PATCH] CIFS should honour umask

[Steve French]

For the non-unix case (e.g. Windows servers) the mode will be taken
from the default specified on the mount. I am not sure if we also
should add code to also honor umask in that case.

I am not sure how common it is to change umask to different values in
different processes which would access the same mount.

Thoughts?

> Steve French wrote:
> > Thanks - it looks almost right but you missed mknod case and your
> > patch had some whitespace/formatting problems.
> >
> > Could you try the following and make sure it works for you?  If so
> > will merge.