[linux-cifs-client] Re: compile cifs-1.48a error on CentOS 4.3

[Jeff Layton]

On Wed, 11 Jul 2007 13:28:00 +0700
kemas <k_henry at ramayana.co.id> wrote:

> On Tue, 2007-07-10 at 10:31 -0400, Jeff Layton wrote:
> > On Tue, 10 Jul 2007 08:19:06 +0700
> > kemas <k_henry at ramayana.co.id> wrote:
> > 
> > > Hi Akemi,
> > > 
> > > sorry for late reply, been out of office for 2 days.
> > > Yup, I've download cifs-1.48a from
> > > http://pserver.samba.org/samba/ftp/cifs-cvs/cifs-1.48a.tar.gz, but when
> > > I compile the kernel it throws error like this
> > > 
> > > CC [M]  fs/cifs/cifsfs.o
> > > In file included from fs/cifs/cifsfs.c:40:
> > > fs/cifs/cifsproto.h:369: error: conflicting types for 'kzalloc'
> > > include/linux/slab.h:101: error: previous declaration of'kzalloc' was
> > > here
> > > fs/cifs/cifsproto.h:369: error: conflicting types for 'kzalloc'
> > > include/linux/slab.h:101: error: previous declaration of'kzalloc' was
> > > here    make[2]: *** [fs/cifs/cifsfs.o] Error 1
> > > make[1]: *** [fs/cifs] Error 2
> > > make: *** [fs] Error 2
> > > 
> > > I'm so curious to test Jeff Layton patch that you told me last night
> > > (not sleeping and bouncing my head), but when I apply the patch to my
> > > kernel (kernel source from 2.6.9 from Centos), some patch were rejected,
> > > maybe because my fault not applying the patch correctly.
> > > 
> > > what I did last night like this, correct me if I'm wrong
> > > 
> > > #tar xvzf cifs-1.48a.tar.gz
> > > #cp cifs-bld-tmp/fs/cifs/* /usr/src/linux/fs/cifs
> > > #make mrproper
> > > #make oldconfig
> > > #patch -p1 < 0010-BZ-239939-Update-CIFS-to-1.48aRH.patch
> > > ...several files rejected
> > > #make
> > > ...still the same error
> > > 
> > > but when I change 2 files (cifsproto.h and cifsfs.c) that had
> > > declaration 'kzalloc' like Jeff Layton patch, and 1 file (inode.c) that
> > > has variable 'rlim', the compile process is running now.
> > > 
> > > Don't know if the module going to work because some code were alter like
> > > that. Or perhaps someone has nicer way to do this?
> > > 
> > > 
> > > thank you
> > > kemas
> > > 
> > > 
> > > 
> > > 
> > > On Sun, 2007-07-08 at 23:16 -0700, Akemi Yagi wrote:
> > > > On Sat, 07 Jul 2007 08:59:27 -0700, Akemi Yagi wrote:
> > > > 
> > > > > On Sat, 07 Jul 2007 15:38:32 +0700, kemas wrote:
> > > > > 
> > > > >> hi,
> > > > >> 
> > > > >> I would like to update my cifs kernel module from 1.34 to 1.48, but it
> > > > >> always fail.
> > > > >> I read on net that you need to apply some patch to compile newer cifs on
> > > > >> older kernel like mine (CentOS 4.3 stock kernel 2.6.9-34.ELsmp).
> > > > >> 
> > > > >> is there a guide or howto to compile cifs on older kernel and where to
> > > > >> download the patch.
> > > > >> 
> > > > >> thank you
> > > > > 
> > > > > Is this the source file you tried but did not compile?
> > > > > 
> > > > > http://pserver.samba.org/samba/ftp/cifs-cvs/cifs-1.48a.tar.gz
> > > > > 
> > > > > Akemi
> > > > 
> > > > Jeff Layton built test kernels for RHEL 4 and 5 with the above cifs code. 
> > > > You can try the RHEL 4 version for your CentOS 4. [And report the test
> > > > results back]
> > > > 
> > > > http://people.redhat.com/jlayton/
> > > > 
> > > > Akemi
> > > > 
> > > > 
> 
> > 
> > You'll probably have better luck starting with a 4.5 kernel. From the
> > subject, it sounds like you're starting from 4.3 (which I assume is
> > based on RHEL4.3).
> > 
> 
> is 4.3 and 4.5 RHEL kernel differ in include/linux/slab.h ?
> 

I'm not sure -- you'd need to diff the sources to know (or compare
patches in the srpm). My comment was more directed at the problems you
were having in applying the patch from my people page. That patch is
against a more recent kernel than 4.3.

-- 
Jeff Layton <jlayton at redhat.com>