[linux-cifs-client] Re: [PATCH] [CIFS] Remove mem dump of key payload from cifs_get_spnego_key

[Steve French]

What if we dumped only the first part of the blob when CONFIG_CIFS_DEBUG2?

Presumably we could get that from dumping the smb as well - I was
considering writing a utility script to convert the traceSMB entries in
dmesg to be wireshark readable - has anyone else done this already?

On Dec 15, 2007 10:45 AM, Jeff Layton <jlayton at redhat.com> wrote:

> From: Jeff Layton <jlayton at tleilax.poochiereds.net>
>
> Now that SPNEGO upcalls are generally working, there's little need to dump
> the key payload to the ring buffer when cifsFYI is turned up. It could
> complicate later debugging (particularly if the key payload is large).
>
> Signed-off-by: Jeff Layton <jlayton at redhat.com>
> ---
>  fs/cifs/cifs_spnego.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/fs/cifs/cifs_spnego.c b/fs/cifs/cifs_spnego.c
> index 1529d2b..83a426e 100644
> --- a/fs/cifs/cifs_spnego.c
> +++ b/fs/cifs/cifs_spnego.c
> @@ -121,13 +121,6 @@ cifs_get_spnego_key(struct cifsSesInfo *sesInfo)
>
>        cFYI(1, ("key description = %s", description));
>        spnego_key = request_key(&cifs_spnego_key_type, description, "");
> -
> -       if (cifsFYI && !IS_ERR(spnego_key)) {
> -               struct cifs_spnego_msg *msg = spnego_key->payload.data;
> -               cifs_dump_mem("SPNEGO reply blob:", msg->data,
> -                               msg->secblob_len + msg->sesskey_len);
> -       }
> -
>  out:
>        kfree(description);
>        return spnego_key;
> --
> 1.5.3.6
>
>


-- 
Thanks,

Steve
-------------- next part --------------
HTML attachment scrubbed and removed