[linux-cifs-client] Re: [PATCH 01/25] VFS: move attr_kill logic
from notify_change into helper function
Christoph Hellwig
hch at infradead.org
Tue Aug 7 20:51:54 GMT 2007
> +void attr_kill_to_mode(struct inode *inode, struct iattr *attr)
This function badly needs a kerneldoc description. Also I can't say
I like the name a lot, but without a clearly better idea I should
probably not complain :)
We should at least add a generic_ prefix to indicate it's a generic
helper valid for most filesystem (and the kerneldoc comment can explain
the details)
More information about the linux-cifs-client
mailing list