[linux-cifs-client] Re: [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean

Richard Knutsson ricknu-0 at student.ltu.se
Fri Sep 1 13:42:58 GMT 2006


Jan Engelhardt wrote:

>>--- a/fs/cifs/asn1.c	2006-09-01 01:24:45.000000000 +0200
>>+++ b/fs/cifs/asn1.c	2006-09-01 02:43:09.000000000 +0200
>>@@ -457,7 +457,7 @@ decode_negTokenInit(unsigned char *secur
>>unsigned char *sequence_end;
>>unsigned long *oid = NULL;
>>unsigned int cls, con, tag, oidlen, rc;
>>-	int use_ntlmssp = FALSE;
>>+	int use_ntlmssp = false;
>>    
>>
>
>Should not this become 'bool use_ntlmssp'? Possibly in a later patch?
>  
>
I would like to, but there has been complaints on changing 'int''s into 
'bool''s, so until there is a more formal decision on this...
Of course I would be happy to make a 'int'->'bool'-patch if a maintainer 
wants it.

>
>Jan Engelhardt
>  
>
Richard Knutsson



More information about the linux-cifs-client mailing list