[linux-cifs-client] pending cifs stable fixes ok but delay until 2.6.17 goes out?

Steven French sfrench at us.ibm.com
Fri May 26 18:27:00 GMT 2006





Andrew,
Just wanted to double check our tentative decision to defer pushing the current cifs-stable
tree bug fixes into mainline until 2.6.17 comes out.  The tree
      rsync://rsync.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6-stable.git
recently finished testing out ok, looks fine and contains only low risk fixes, but it looks
like it is too late to recommend pushing it upstream right?   There is a much bigger
change (Note: that the backlevel server support for cifs client which is needed
in order to deprecate smbfs, and enable better security negotation, and which is
much larger,  and thus in a distinct tree temporarily while I am testing,
is not included in the list below).   The following fixes could be pushed easily enough
and include:
      - a small memory leak on every session reconnect (after e.g. server or network failure)
      - working support for advisory posix locking to current samba (with /proc/fs/cifs/Experimental on)
      - a fix for a rare oops
      - a fix for long share names in certain asian languages
      - a fix for passing O_TRUNC which works around a bug in a less common NAS appliance

and would update the following files:

 fs/cifs/CHANGES     |    7 +++
 fs/cifs/cifsfs.h    |    2 -
 fs/cifs/cifsproto.h |    2 -
 fs/cifs/cifssmb.c   |   40 ++++++++++++++++++---
 fs/cifs/connect.c   |   97 +++++++++++++++++++++++++++++++++++++++++++++++-----
 fs/cifs/file.c      |   12 ++++--
 6 files changed, 140 insertions(+), 20 deletions(-)

through these ChangeSets:

commit 209401d400623bb8eb72b304424d81cddb35e3d9
tree 8c87642232743ac9da7f230b678409a8358244d0
parent 49841d8636f2edfc6c27fc86c9b4435d9d0180c4
author Steve French <sfrench at us.ibm.com> Wed, 24 May 2006 16:17:39 +0000
committer Steve French <sfrench at us.ibm.com> Wed, 24 May 2006 16:17:39 +0000

    [CIFS] Pass truncate open flag through on file open in case setattr fails
    on set size to zero.

    Signed-off-by: Sebastian Voitzsch <sebastoam/vpotzscj at web.de>
    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 49841d8636f2edfc6c27fc86c9b4435d9d0180c4
tree 5124703f57cbbed11c9a87c1a17ee8a18682914b
parent 8ba86486650c59f969c589c7d6c3dd4da734c75a
parent 353b28bafd1b962359a866ff263a7fad833d29a1
author Steve French <sfrench at us.ibm.com> Mon, 22 May 2006 16:06:10 +0000
committer Steve French <sfrench at us.ibm.com> Mon, 22 May 2006 16:06:10 +0000

    Merge with /pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 8ba86486650c59f969c589c7d6c3dd4da734c75a
tree 5ff38a5b577273b051386ad57fc523b7a6e7b013
parent 7478a94ba73721e78bee80215a71f106fe14f612
parent a54c9d30dbb06391ec4422aaf0e1dc2c8c53bd3e
author Steve French <sfrench at us.ibm.com> Thu, 18 May 2006 21:30:57 +0000
committer Steve French <sfrench at us.ibm.com> Thu, 18 May 2006 21:30:57 +0000

    Merge with /pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 7478a94ba73721e78bee80215a71f106fe14f612
tree e36412ab4542bfae9b2715b8e0f8915037fd86c2
parent 7e57fe1cbca285dcb6f90f03fbb55ae9f2328924
author Steve French <sfrench at us.ibm.com> Thu, 18 May 2006 18:25:59 +0000
committer Steve French <sfrench at us.ibm.com> Thu, 18 May 2006 18:25:59 +0000

    [CIFS] Fix typos in previous fix

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 7e57fe1cbca285dcb6f90f03fbb55ae9f2328924
tree 6361bbe98d708f406e184bca5bba4685feab392b
parent eedd2970e0efc0af3e3c038333a80e02e5eb5722
parent 9676489866a75fdd56b0d3e40ec7884298bb1338
author Steve French <sfrench at us.ibm.com> Thu, 18 May 2006 02:09:11 +0000
committer Steve French <sfrench at us.ibm.com> Thu, 18 May 2006 02:09:11 +0000

    Merge with /pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit eedd2970e0efc0af3e3c038333a80e02e5eb5722
tree 084f1cddc0481d85dd1e751bc135a89ac96637e8
parent db20a979fd7c13bb11d6687d01034998b16d3156
author Steve French <sfrench at us.ibm.com> Wed, 17 May 2006 23:15:14 +0000
committer Steve French <sfrench at us.ibm.com> Wed, 17 May 2006 23:15:14 +0000

    [CIFS] endian fix for new POSIX byte range lock support
    Signed-off-by: Alexey Dobriyan <adobriyan at gmail.com>
    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit db20a979fd7c13bb11d6687d01034998b16d3156
tree ffd1d33dc11dd7aa8c50bda84ddf6c69396ce6ab
parent 9153bfb3d0f1d47ce13de0f074f13f90d3571ff1
author Steve French <sfrench at us.ibm.com> Wed, 17 May 2006 23:11:08 +0000
committer Steve French <sfrench at us.ibm.com> Wed, 17 May 2006 23:11:08 +0000

    [CIFS] fix memory leak in cifs session info struct on reconnect

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 9153bfb3d0f1d47ce13de0f074f13f90d3571ff1
tree efb0d4a5a0674c26da9697a39065848bc0111a10
parent dd88f73ef7cc81dc6dd3eb94d8f89a164d995f26
author Steve French <sfrench at us.ibm.com> Wed, 17 May 2006 22:49:39 +0000
committer Steve French <sfrench at us.ibm.com> Wed, 17 May 2006 22:49:39 +0000

    [CIFS] ACPI suspend oops

    Wasn't able to reproduce a hard hang, but was able to get an oops if
    suspended the machine during a copy to the cifs mount.  This led to some
    things
    hanging, including a "sync".  Also got I/O errors when trying to
    access the mount afterwards (even when didn't see the oops), and had
    to unmount and remount in order to access the filesystem.

    This patch fixed the oops.

    Signed-off-by: Dave Kleikamp <shaggy at austin.ibm.com>
    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit dd88f73ef7cc81dc6dd3eb94d8f89a164d995f26
tree 53ab07699d73da2456df8d17e50586a973840c10
parent 64df97b4f0010b58fc777aee26742e91eb66c8f5
parent 6810b548b25114607e0814612d84125abccc0a4f
author Steve French <sfrench at us.ibm.com> Tue, 09 May 2006 04:08:32 +0000
committer Steve French <sfrench at us.ibm.com> Tue, 09 May 2006 04:08:32 +0000

    Merge with /pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 64df97b4f0010b58fc777aee26742e91eb66c8f5
tree 897e818b8f1f8f46956074cfbab96dfb7363cc99
parent 2d84d92dc97a4b0548a7d27ab0344da031e6821b
parent ebf34c9b6fcd22338ef764b039b3ac55ed0e297b
author Steve French <sfrench at us.ibm.com> Tue, 02 May 2006 21:47:44 +0000
committer Steve French <sfrench at us.ibm.com> Tue, 02 May 2006 21:47:44 +0000

    Merge with /pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 2d84d92dc97a4b0548a7d27ab0344da031e6821b
tree 3d05d1a59485624bff59e6e3faadfcd1d439269a
parent 20ca2f0ccabfe548ca144cb7c649c2d3d81b872d
author Steve French <sfrench at us.ibm.com> Tue, 02 May 2006 21:41:23 +0000
committer Steve French <sfrench at us.ibm.com> Tue, 02 May 2006 21:41:23 +0000

    [CIFS] Do not limit the length of share names (was 100 for whole UNC name) during
    mount. Especially important for some non-Western languages.

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 20ca2f0ccabfe548ca144cb7c649c2d3d81b872d
tree e7834f82c2573a6896136f44705cb71010a4fe08
parent 59755e7526c81db30c082306a4459425e0eeaaa0
parent 1f4a90670bacbf61f2fcc19a9e0e78748c932a25
author Steve French <sfrench at us.ibm.com> Mon, 01 May 2006 17:05:36 +0000
committer Steve French <sfrench at us.ibm.com> Mon, 01 May 2006 17:05:36 +0000

    Merge with /pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit 59755e7526c81db30c082306a4459425e0eeaaa0
tree 7ed860da1ee5ed6e085b6d533a8414b7a5bb50ad
parent fcb63b946bfbbba5cf23364978b4ec6c4806bda6
parent 2be4d50295e2b6f62c07b614e1b103e280dddb84
author Steve French <sfrench at us.ibm.com> Thu, 27 Apr 2006 09:45:46 +0000
committer Steve French <sfrench at us.ibm.com> Thu, 27 Apr 2006 09:45:46 +0000

    Merge with /pub/scm/linux/kernel/git/torvalds/linux-2.6.git

    Signed-off-by: Steve French <sfrench at us.ibm.com>

commit fcb63b946bfbbba5cf23364978b4ec6c4806bda6
tree 4e8525a399a66a8889dc0618ed6e7cb97a8f6113
parent 301dc3e6f6ea83703fa52919c00e60661da5a8fe
author Steve French <sfrench at us.ibm.com> Tue, 25 Apr 2006 16:41:13 +0000
committer Steve French <sfrench at us.ibm.com> Tue, 25 Apr 2006 16:41:13 +0000

    FS] Fix new POSIX Locking for setting lock_type correctly on unlock

    Signed-off-by: Steve French <sfrench at us.ibm.com>


Opinion?

Steve French
Senior Software Engineer
Linux Technology Center - IBM Austin
phone: 512-838-2294
email: sfrench at-sign us dot ibm dot com
-------------- next part --------------
HTML attachment scrubbed and removed


More information about the linux-cifs-client mailing list