[linux-cifs-client] Re: [GIT] cifs fix

Steve French smfrench at austin.rr.com
Sun Mar 5 07:58:34 GMT 2006


Linus Torvalds wrote:

>You can't cut-and-paste patches. They'll invariably be corrupted. So is 
>this one. Horrible whitespace problems.
>  
>

Linus, please pull from

rsync://rsync.kernel.org/pub/scm/linux/kernel/git/sfrench/cifs-2.6-stable.git

This will update the following files:

 fs/cifs/cifsproto.h |    2 +-
 fs/cifs/connect.c   |    2 +-
 fs/cifs/misc.c      |    4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

through these ChangeSets:

commit e77e6f3be93763ef88ccbaa9e0ebda5360d92f7c
tree 35260c1d1968c448af77c267814d925d3c62f475
parent 501f74f29498543c27f4f9697f5c1e980dd2de0d
author Steve French <sfrench at us.ibm.com> Sun, 05 Mar 2006 03:39:55 +0000
committer Steve French <sfrench at us.ibm.com> Sun, 05 Mar 2006 03:39:55 +0000

    [CIFS] Always match oplock break (cache notification) to the right tcp
    session when multiply mounted.

    Fixes slow response when cifs client is mounted to shares on multiple
    servers and oplock break occurs (usually due to attempt to multiply 
open a
    file).  When treeids on mutiple mounted shares match and we find the 
wrong
    match first, we searched for the wrong cached files to send oplock break
    response for which usually meant that no matching file was found and 
thus
    the server would have to timeout the notification.  Oplock break 
timeout is
    about 20 seconds on some servers so this could cause significantly 
slower
    performance on file open calls in a few cases (in particular when 
multiple
    shares are mounted from multiple servers, tree ids match, and we have a
    cached file which is later opened multiple times).  This was the most
    important of the bugs that was found and fixed at Connectathon
    (interoperability testing event) this week.

    Acked-by:  Shaggy (shaggy at austin.ibm.com)
    Signed-off-by: Steve French (sfrench at us.ibm.com)


GIT is easier than patch after all.


More information about the linux-cifs-client mailing list